-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Eth Transaction for EIP2718 #1354
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1354 +/- ##
==========================================
- Coverage 95.41% 95.39% -0.02%
==========================================
Files 443 443
Lines 13401 13336 -65
==========================================
- Hits 12786 12722 -64
+ Misses 615 614 -1
Continue to review full report at Codecov.
|
Postpone committing EIP2718 support to the time when EIP1559 is approaching. |
* Add new fields to Ethereum proto. * Legacy transaction building. * Typescript test update * TS test fix * Compiler warning fix (ios) * Legacy and Enveloped transactions. * lSigner. Refactor Transaction * AccessList generation test (wip) * Cleanup, small refactor * Signer build change, make it more generic. * Copyright year * SignatureRSV rename. * Signer class is static now, no chainID memeber. * Renames, Legacy * Minor touches * Rename, hash * Minor reorg in sign() Co-authored-by: Catenocrypt <[email protected]>
* Add new fields to Ethereum proto. * Legacy transaction building. * Typescript test update * TS test fix * Compiler warning fix (ios) * Legacy and Enveloped transactions. * lSigner. Refactor Transaction * AccessList generation test (wip) * Cleanup, small refactor * Signer build change, make it more generic. * Copyright year * SignatureRSV rename. * Signer class is static now, no chainID memeber. * Renames, Legacy * Minor touches * Rename, hash * Minor reorg in sign() Co-authored-by: Catenocrypt <[email protected]>
Description
Refactor Eth Transaction, for legacy and enveloped EIP2718 transactions. EIP2718 is a prerequisite for upcoming EIP1559 new fee structure, and EIP2718 is part of the Berlin update, expected to to arrive mid-April.
Related to #1322 .
Testing instructions
Unit tests.
Types of changes
Checklist
[WIP]
if necessary.